-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replaced old logo with new logo, updated css properties #51
Conversation
👷 Deploy request for curiocic pending review.Visit the deploys page to approve it
|
@sdthaker is attempting to deploy a commit to the cur-io Team on Vercel. A member of the Team first needs to authorize it. |
UpdateWith the commit 59ed1b7 the div that contains the logo and curio text looks like this for better visibility for smaller screen size: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sdthaker very nice work. Some comments below
Please make sure to synchronize your working branch before as I've added those logos in #54 |
62c700c
to
706779a
Compare
Added the requested changes in commit 706779a <768 screen size:>= 768 screen size:Please let me know if anything else needs to be changed for this PR. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @sdthaker 🙂, some suggestions below.
2faa092
to
c023c9a
Compare
Changes after commit 5d3b797: |
Changes Made
Your Video Translator :)
to align it with the logo for both screen sizes.Curio
text for both screen sizes.<img>
tag in order to show the correct logo on the websiteChanges in action
When screen size is >= 768px
When screen size is < 768px
Issue
Additional Notes
Please let me know if you want something added/removed as part of this PR, eg. if you'd want me to add/remove padding, margin or width changes, etc. @arjxn-py