Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced old logo with new logo, updated css properties #51

Merged
merged 6 commits into from
Oct 12, 2023

Conversation

sdthaker
Copy link
Contributor

@sdthaker sdthaker commented Oct 10, 2023

Changes Made

  • Removed width for logo. Now uses default width.
  • Removed left-right padding from the span text Your Video Translator :) to align it with the logo for both screen sizes.
  • Removed the span tag with Curio text for both screen sizes.
  • Linked correct logo source to the <img> tag in order to show the correct logo on the website

Changes in action

When screen size is >= 768px

image

When screen size is < 768px

image

Issue

Additional Notes

Please let me know if you want something added/removed as part of this PR, eg. if you'd want me to add/remove padding, margin or width changes, etc. @arjxn-py

@netlify
Copy link

netlify bot commented Oct 10, 2023

👷 Deploy request for curiocic pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 706779a

@vercel
Copy link

vercel bot commented Oct 10, 2023

@sdthaker is attempting to deploy a commit to the cur-io Team on Vercel.

A member of the Team first needs to authorize it.

@sdthaker
Copy link
Contributor Author

Update

With the commit 59ed1b7 the div that contains the logo and curio text looks like this for better visibility for smaller screen size:

image

Copy link
Member

@arjxn-py arjxn-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sdthaker very nice work. Some comments below

src/components/Header/Header.tsx Show resolved Hide resolved
src/components/Header/Header.tsx Show resolved Hide resolved
@arjxn-py
Copy link
Member

Please make sure to synchronize your working branch before as I've added those logos in #54

@sdthaker
Copy link
Contributor Author

sdthaker commented Oct 11, 2023

Added the requested changes in commit 706779a

<768 screen size:

image

>= 768 screen size:

image

Please let me know if anything else needs to be changed for this PR.

@vercel
Copy link

vercel bot commented Oct 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
curio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 0:16am

Copy link
Member

@arjxn-py arjxn-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @sdthaker 🙂, some suggestions below.

src/components/Header/header.css Outdated Show resolved Hide resolved
src/components/Header/header.css Show resolved Hide resolved
@sdthaker
Copy link
Contributor Author

Changes after commit 5d3b797:

image

@arjxn-py arjxn-py merged commit c1911d1 into Curio-org:main Oct 12, 2023
2 checks passed
@arjxn-py arjxn-py linked an issue Oct 14, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update logo on website
2 participants