fix: align XML schema with JSON schema for Dependency type #146
#158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…X#146 Signed-off-by: Paul Horton <[email protected]>
jkowalleck
requested changes
Sep 13, 2022
| @@ -1186,11 +1186,11 @@ limitations under the License. | |||
|
|
|||
| <xs:complexType name="dependencyType"> | |||
| <xs:sequence minOccurs="0" maxOccurs="unbounded"> | |||
| <xs:element name="dependency" type="bom:dependencyType"/> | |||
| <xs:element name="dependency" type="bom:refType"/> | |||
There was a problem hiding this comment.
❌ this is a breaking change.
the following would no longer be valid, but was valid before
<bom nmlns="http://cyclonedx.org/schema/bom/1.4">
<dependencies>
<dependency ref="foo">
<dependencies>
<dependency ref="bar" />
</dependencies>
</dependency>
</dependencies>
</bom>There was a problem hiding this comment.
You are not wrong - this is a breaking change. Does this mean we have to wait until 1.5 to get this "aligned"?
There was a problem hiding this comment.
@stevespringett , @CycloneDX/core-team , @CycloneDX/industry-working-group
|
@madpah could you check if the bug was already fixed in the upcoming 1.5? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update XML schema to align with JSON schema for
dependencytypefixes #146