chore: put capacity for benchmark

Cysharp · Nov 5, 2024 · a8d8fca · a8d8fca
1 parent 3ab545b
commit a8d8fca
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 10 deletions.
diff --git a/perf/BenchmarkApp/PerformanceTest.Client/PerformanceTestRunningContext.cs b/perf/BenchmarkApp/PerformanceTest.Client/PerformanceTestRunningContext.cs
@@ -35,6 +35,13 @@ public void Ready()
         hardwarePerformanceReporter.Start();
     }
 
+    public void Complete()
+    {
+        isRunning = false;
+        stopwatch.Stop();
+        hardwarePerformanceReporter.Stop();
+    }
+
     public void Increment()
     {
         if (isRunning)
@@ -62,13 +69,6 @@ public void Error()
         Interlocked.Increment(ref errorsPerConnection);
     }
 
-    public void Complete()
-    {
-        isRunning = false;
-        stopwatch.Stop();
-        hardwarePerformanceReporter.Stop();
-    }
-
     public PerformanceResult GetResult()
     {
         var latency = MeasureLatency(latencyPerConnection);

diff --git a/perf/BenchmarkApp/PerformanceTest.Client/Program.cs b/perf/BenchmarkApp/PerformanceTest.Client/Program.cs
@@ -91,7 +91,7 @@ async Task Main(
         {
             if (!resultsByScenario.TryGetValue(scenario2, out var results))
             {
-                results = new List<PerformanceResult>();
+                results = new List<PerformanceResult>(10000);
                 resultsByScenario[scenario2] = results;
             }
             var result = await RunScenarioAsync(scenario2, config, config.ChannelList, controlServiceClient);
@@ -103,7 +103,6 @@ async Task Main(
     }
     WriteLog($"All scenario complete");
 
-
     WriteLog($"Saving metrics...");
     foreach (var (s, results) in resultsByScenario)
     {
@@ -314,7 +313,7 @@ IEnumerable<ScenarioType> GetRunScenarios(ScenarioType scenario)
     return scenario switch
     {
         ScenarioType.All => Enum.GetValues<ScenarioType>().Where(x => x != ScenarioType.All && x != ScenarioType.CI),
-        //ScenarioType.CI => Enum.GetValues<ScenarioType>().Where(x => x == ScenarioType.Unary || x == ScenarioType.StreamingHub || x == ScenarioType.ServerStreaming),
+        // Do not include ServerStreaming to CI. ServerStreaming consume a lot of resource and will impact later scenarios.
         ScenarioType.CI => Enum.GetValues<ScenarioType>().Where(x => x == ScenarioType.Unary || x == ScenarioType.StreamingHub),
         _ => [scenario],
     };