-
-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MagicOnion.Client.SourceGenerator #688
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a source generator for platform that require pre-generated client code (e.g. Unity, NativeAOT, MAUI ...).
The source generator also replaces MagicOnion.Generator (moc).
Introduce MagicOnion.Client.SourceGenerator
MagicOnion.Client.SourceGenerator is shipped with MagicOnion.Client package.
This means that you no longer need to the install generator tool (moc) and setup additional build steps.
Supported development environments
Usage
Define a
partial
class with any name of your choosing within the application. Mark it with theMagicOnionClientGeneration
attribute, and specify any service type found within the assembly where you want to search for the service interface.For example, if the
MyApp.Shared
assembly containsMyApp.Shared.Services.IGreeterService
andMyApp.Shared.Hubs.IChatHub
, specify one of them.Next, configure MessagePack to use the generated MessagePack Resolver. This is the same as when using the legacy MagicOnion.Generator.
Source generation options
You can specify options in the named constructor of the attribute.
DisableAutoRegistration
: Sets whether to disable automatically callingRegister
during start-up. (Automatic registration requires .NET 5+ or Unity)MessagePackFormatterNamespace
: Sets the namespace of pre-generated MessagePackFormatters. The default value isMessagePack.Formatters
.Serializer
: Sets the serializer used for message serialization. The default value isGenerateSerializerType.MessagePack
.Breaking changes
MagicOnion.Generator (moc) has been removed. The legacy generator is no longer supported.
Warning
While there is currently compatibility between MagicOnion.Client and MagicOnion.Generator (moc), there is no guarantee that this will be maintained.