Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7: Add JSON validation #122

Merged
merged 11 commits into from
Sep 29, 2024
Merged

#7: Add JSON validation #122

merged 11 commits into from
Sep 29, 2024

Conversation

maxime-bfsquall
Copy link
Contributor

Fixes #7

@maxime-bfsquall maxime-bfsquall self-assigned this Sep 23, 2024
@maxime-bfsquall maxime-bfsquall requested review from ppebay and removed request for pierrepebay September 23, 2024 13:41
@maxime-bfsquall maxime-bfsquall force-pushed the 7-add-json-validation branch 4 times, most recently from 0093b7e to 1aee5f2 Compare September 24, 2024 09:52
@tlamonthezie tlamonthezie changed the title #7 Add JSON validation #7: Add JSON validation Sep 27, 2024
Copy link
Contributor

@tlamonthezie tlamonthezie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation works correctly with both python bindings and standalone app
I have just some minor changes to request.

src/vt-tv/utility/parse_render.cc Show resolved Hide resolved
ci/docker/build-and-test-ubuntu.dockerfile Show resolved Hide resolved
ci/setup_conda.sh Show resolved Hide resolved
scripts/json_datafile_validator.py Outdated Show resolved Hide resolved
src/vt-tv/utility/json_reader.cc Outdated Show resolved Hide resolved
@maxime-bfsquall maxime-bfsquall merged commit 0030760 into master Sep 29, 2024
12 checks passed
@maxime-bfsquall maxime-bfsquall deleted the 7-add-json-validation branch September 29, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add JSON validation
3 participants