generated from DARMA-tasking/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#7: Add JSON validation #122
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxime-bfsquall
requested review from
lifflander,
tlamonthezie and
pierrepebay
September 23, 2024 13:37
maxime-bfsquall
requested review from
ppebay
and removed request for
pierrepebay
September 23, 2024 13:41
maxime-bfsquall
force-pushed
the
7-add-json-validation
branch
4 times, most recently
from
September 24, 2024 09:52
0093b7e
to
1aee5f2
Compare
maxime-bfsquall
force-pushed
the
7-add-json-validation
branch
from
September 26, 2024 12:34
1aee5f2
to
b336f99
Compare
maxime-bfsquall
force-pushed
the
7-add-json-validation
branch
from
September 26, 2024 13:51
5022a1f
to
013fccd
Compare
ppebay
approved these changes
Sep 27, 2024
tlamonthezie
previously requested changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validation works correctly with both python bindings and standalone app
I have just some minor changes to request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7