Optimize - remove qoi context string manipulation, update ciemss version #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Tom-Szendrey
changed the title
mwdchang
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
_stateor_observabledepending on the selection. It is much easier to do this string manip in the hmi-client as it readily has the model while setting up the dropdown optionsRelated + required:
DARPA-ASKEM/terarium#4564
Testing
-Testing via HMI optimize drilldown.
-running ciemss notebooks locally to ensure sending qoi, risk_bound, and alpha as non lists is caught properly by
https://github.com/ciemss/pyciemss/blob/main/pyciemss/interfaces.py#L876-L881
Pyciemss updates:
ciemss/pyciemss#596 -> Allows for multiple constraints, contains backwards compatibility
ciemss/pyciemss#602 -> The changes required for this specific PR
ciemss/pyciemss#592 -> Allows for intermediate results