Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update interventions to have distinct param and state. #115

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

Tom-Szendrey
Copy link
Contributor

Description

The interfaces in ciemss utilize different inputs for state and parameter interventions.
https://github.com/ciemss/pyciemss/blob/main/pyciemss/interfaces.py

This PR addresses this and corrects the converter in pyciemss-service.

image

Copy link
Contributor

@dgauldie dgauldie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tom-Szendrey Tom-Szendrey merged commit 05f8e46 into main Aug 28, 2024
2 checks passed
@Tom-Szendrey Tom-Szendrey deleted the TS/4548-state-interventions branch November 1, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Simulate with interventions fail
3 participants