Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize: Update obj func #125

Merged
merged 10 commits into from
Nov 5, 2024
Merged

Optimize: Update obj func #125

merged 10 commits into from
Nov 5, 2024

Conversation

Tom-Szendrey
Copy link
Contributor

@Tom-Szendrey Tom-Szendrey commented Nov 5, 2024

Description:

  • Clean - update many of the loose strings to enums as we know what they are expected to be.
  • Fix - Since we have added relative weights using start_time_param_value would break our objective function. This was written with the assumption that length of x === length of interventions but this is not the case when we provide start_time_param_value as it will increase interventions by 1 and x by 2

Testing:

Run optimizes that do not include start_time_param_value -> Should pass as before
Run optimizes that do include start_time_param_value -> Should now pass

Example: while running with very minimal iterations and function eval (1-3, 1-3) we expect the result to be at or very close to the initial guess. We therefore expect to the resulting order to be: 1, 20, 0.2, 30
1st:
image

2nd:
image

3rd:
image

Result:
image

@Tom-Szendrey Tom-Szendrey marked this pull request as ready for review November 5, 2024 15:32
Copy link
Contributor

@blanchco blanchco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't test, but looks good

@liunelson liunelson merged commit b66648d into main Nov 5, 2024
2 checks passed
Copy link
Member

@liunelson liunelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants