Disable "increases to above" dropdown in the Create Intervention Poli… (

#4820)

Co-authored-by: Tom Szendrey <[email protected]>

packages/client/hmi-client/src/components/workflow/ops/intervention-policy/tera-intervention-card.vue

@@ -105,13 +105,7 @@
 						option-value="value"
 						placeholder="Select a trigger"
 					/>
-					<Dropdown
-						:model-value="intervention.dynamicInterventions[0].isGreaterThan"
-						@change="onComparisonOperatorChange"
-						:options="comparisonOperations"
-						option-label="label"
-						option-value="value"
-					/>
+					crosses the threshold
 					<tera-input-number
 						auto-width
 						:model-value="intervention.dynamicInterventions[0].threshold"
@@ -175,11 +169,6 @@ const interventionType = computed(() => {
 	return 'static';
 });
 
-const comparisonOperations = [
-	{ label: 'increases to above', value: true },
-	{ label: 'decreases to below', value: false }
-];
-
 const onUpdateName = (name: string) => {
 	const intervention = cloneDeep(props.intervention);
 	intervention.name = name;
@@ -243,8 +232,7 @@ const onInterventionTypeChange = (value: string) => {
 			{
 				threshold: Number.NaN,
 				value: Number.NaN,
-				parameter: '',
-				isGreaterThan: true
+				parameter: ''
 			}
 		];
 	}
@@ -258,12 +246,6 @@ const onTargetParameterChange = (event: DropdownChangeEvent) => {
 	emit('update', intervention);
 };
 
-const onComparisonOperatorChange = (event: DropdownChangeEvent) => {
-	const intervention = cloneDeep(props.intervention);
-	intervention.dynamicInterventions[0].isGreaterThan = event.value;
-	emit('update', intervention);
-};
-
 const onSemanticChange = (event: DropdownChangeEvent) => {
 	const intervention = cloneDeep(props.intervention);
 	intervention.type = event.value;

packages/client/hmi-client/src/components/workflow/ops/intervention-policy/tera-intervention-policy-drilldown.vue

@@ -120,9 +120,7 @@
 											Set {{ intervention.type }} {{ appliedTo }} to
 											{{ intervention.dynamicInterventions[0].value }} when the
 											{{ intervention.dynamicInterventions[0].parameter }}
-											{{
-												intervention.dynamicInterventions[0].isGreaterThan ? 'increases to above' : 'decreases to below'
-											}}
+											when it crosses the threshold value
 											{{ intervention.dynamicInterventions[0].threshold }}.
 										</p>
 									</li>

packages/client/hmi-client/src/components/workflow/ops/optimize-ciemss/tera-dynamic-intervention-policy-group.vue

@@ -9,9 +9,8 @@
 		</div>
 		<p>
 			Set the {{ config.intervention?.type }}&nbsp; <strong>{{ config.intervention?.appliedTo }}</strong> to
-			<strong>{{ dynamicInterventions[0].threshold }}</strong> days when it
-			<strong>{{ dynamicInterventions[0].isGreaterThan ? 'increase to above' : 'decrease to below' }}</strong>
-			the threshold value <strong>{{ dynamicInterventions[0].value }}</strong> person.
+			<strong>{{ dynamicInterventions[0].threshold }}</strong> days when it crosses the threshold value
+			<strong>{{ dynamicInterventions[0].value }}</strong> person.
 		</p>
 	</div>
 </template>

packages/client/hmi-client/src/components/workflow/ops/simulate-ciemss/tera-intervention-summary-card.vue

@@ -10,9 +10,8 @@
 			</li>
 			<li v-for="(dynamicIntervention, index) in intervention.dynamicInterventions" :key="`dynamic_${index}`">
 				Set the {{ intervention?.type }}&nbsp; <strong>{{ intervention?.appliedTo }}</strong> to
-				<strong>{{ dynamicIntervention.threshold }}</strong> days when it
-				<strong>{{ dynamicIntervention.isGreaterThan ? 'increase to above' : 'decrease to below' }}</strong>
-				the threshold value <strong>{{ dynamicIntervention.value }}</strong> person.
+				<strong>{{ dynamicIntervention.threshold }}</strong> days when it crosses the threshold value
+				<strong>{{ dynamicIntervention.value }}</strong> person.
 			</li>
 		</ul>
 	</section>

packages/client/hmi-client/src/types/Types.ts

@@ -593,7 +593,6 @@ export interface DynamicIntervention {
     parameter: string;
     threshold: number;
     value: number;
-    isGreaterThan: boolean;
 }
 
 export interface Intervention {

packages/server/src/main/java/software/uncharted/terarium/hmiserver/models/simulationservice/interventions/DynamicIntervention.java

@@ -10,15 +10,13 @@ public class DynamicIntervention {
 	private String parameter;
 	private Number threshold;
 	private Number value;
-	private Boolean isGreaterThan;
 
 	@Override
 	public DynamicIntervention clone() {
 		DynamicIntervention clone = new DynamicIntervention();
 		clone.parameter = this.parameter;
 		clone.threshold = this.threshold;
 		clone.value = this.value;
-		clone.isGreaterThan = this.isGreaterThan;
 		return clone;
 	}
 }