Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First pass of using panteras search widget #4359

Closed
wants to merge 16 commits into from
Closed

First pass of using panteras search widget #4359

wants to merge 16 commits into from

Conversation

YohannParis
Copy link
Member

Description

  • Include a summary of the changes and the related issue.
  • Include relevant motivation and context.

Resolves #(issue)

YohannParis
YohannParis commented Aug 2, 2024
View reviewed changes
packages/client/hmi-client/src/utils/debounce-util.ts
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this better than Lodash.debounce()?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much simpler but much more feature-starved.

Lodash support capabilities like cancellation, leading/trailing, plus some safety checks amongst other things.

Base automatically changed from move-primevue-to-version-4 to main August 6, 2024 18:44
@YohannParis
Copy link
Member Author

@dvince2 I think we can delete this PR and associated branch?

@dvince2 dvince2 closed this Oct 3, 2024
@dvince2 dvince2 deleted the dvince/implement_pantera_search_widget branch October 3, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwdchang mwdchang mwdchang left review comments

@jryu01 jryu01 Awaiting requested review from jryu01 jryu01 will be requested when the pull request is marked ready for review jryu01 is a code owner

@Tom-Szendrey Tom-Szendrey Awaiting requested review from Tom-Szendrey Tom-Szendrey will be requested when the pull request is marked ready for review Tom-Szendrey is a code owner

@shawnyama shawnyama Awaiting requested review from shawnyama shawnyama will be requested when the pull request is marked ready for review shawnyama is a code owner

@blanchco blanchco Awaiting requested review from blanchco blanchco will be requested when the pull request is marked ready for review blanchco is a code owner

@asylves1 asylves1 Awaiting requested review from asylves1 asylves1 will be requested when the pull request is marked ready for review asylves1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YohannParis @mwdchang @dvince2