Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save for reuse for simulation assets #4906

Merged
merged 14 commits into from
Sep 27, 2024
Merged

Conversation

blanchco
Copy link
Contributor

@blanchco blanchco commented Sep 24, 2024

Description

  • Ability to save for reuse for simulation objects, depending on the simulation type (optimize, simulate, calibrate) assets will be saved/updated.
  • Created a backend endpoint to handle saving/updating the assets
  • Created a new modal to save assets when saving for re-use on a simulation object, I figured a new component needed to made here since the logic is pretty different to how we are using the tera-save-asset-model.
    Simulation -> save dataset
    Calibrate -> save dataset, update model configuration
    Optimization -> save dataset, update intervention policy

EDIT:
As discussed, output labels will now change if there are multiple outputs. It will arbitrarily choose the first asset to use as the name

Copy link
Collaborator

@dvince2 dvince2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments ^

@blanchco
Copy link
Contributor Author

Im putting this back in draft as per our discussion, I will need to change the output port names

@blanchco blanchco marked this pull request as draft September 24, 2024 20:24
@blanchco blanchco marked this pull request as ready for review September 25, 2024 18:51
@blanchco blanchco merged commit 2aa5ac1 into main Sep 27, 2024
8 checks passed
@blanchco blanchco deleted the save-for-reuse-simulation-assets branch September 27, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: There is no save for reuse in the simulate, calibrate, and optimize components
4 participants