-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
save for reuse for simulation assets #4906
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blanchco
requested review from
dgauldie,
dvince2,
YohannParis,
mwdchang,
jryu01,
Tom-Szendrey,
shawnyama and
asylves1
as code owners
September 24, 2024 18:10
blanchco
commented
Sep 24, 2024
...rver/src/main/java/software/uncharted/terarium/hmiserver/service/data/SimulationService.java
Show resolved
Hide resolved
dvince2
reviewed
Sep 24, 2024
.../java/software/uncharted/terarium/hmiserver/controller/dataservice/SimulationController.java
Outdated
Show resolved
Hide resolved
dvince2
reviewed
Sep 24, 2024
...rver/src/main/java/software/uncharted/terarium/hmiserver/service/data/SimulationService.java
Outdated
Show resolved
Hide resolved
dvince2
requested changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments ^
mwdchang
reviewed
Sep 24, 2024
packages/client/hmi-client/src/services/models/simulation-service.ts
Outdated
Show resolved
Hide resolved
Im putting this back in draft as per our discussion, I will need to change the output port names |
YohannParis
reviewed
Sep 25, 2024
.../java/software/uncharted/terarium/hmiserver/controller/dataservice/SimulationController.java
Show resolved
Hide resolved
YohannParis
approved these changes
Sep 26, 2024
dvince2
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tera-save-asset-model
.Simulation -> save dataset
Calibrate -> save dataset, update model configuration
Optimization -> save dataset, update intervention policy
EDIT:
As discussed, output labels will now change if there are multiple outputs. It will arbitrarily choose the first asset to use as the name