-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Funman output charts #4923
Funman output charts #4923
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should remove those gollm/gollm_task.egg-info
folder and files.
Update from main
to have your .gitignore
up to snuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The results returned from Funman doesn't seem to make sense, for example you are showing the model variable "R"
- It goes up by a factional amount, which is very suspicious given global population is like 1001
- It stays constant after going up a little bit, this seemingly violates the math
- It would be helpful to have visual markers on the chart, where the points are taken. For example your screenshot has the time going by increments of 10, however your chart draws a grid line every 5 steps. This gives a wrong illusion of what Funman is returning. Having the markers are also very helpful for debugging, and we can turn them off later when things are stable.
… into funman-output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job!
Description