Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Funman output charts #4923

Merged
merged 33 commits into from
Oct 2, 2024
Merged

Funman output charts #4923

merged 33 commits into from
Oct 2, 2024

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Sep 25, 2024

Description

  • State chart and parameter charts to show the true/false boxes of the funman result
  • Will handle ambiguous lines in a second pass
  • There seems to be an issue with the states/outputs being saved, I have to redo things sometimes on reload. Might be a workflow saving problem will have to see in another task.

image

@shawnyama shawnyama linked an issue Oct 1, 2024 that may be closed by this pull request
@shawnyama shawnyama marked this pull request as ready for review October 1, 2024 13:45
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should remove those gollm/gollm_task.egg-info folder and files.
Update from main to have your .gitignore up to snuff.

@shawnyama shawnyama changed the title Funman output Funman output charts Oct 1, 2024
Copy link
Member

@mwdchang mwdchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The results returned from Funman doesn't seem to make sense, for example you are showing the model variable "R"
  • It goes up by a factional amount, which is very suspicious given global population is like 1001
  • It stays constant after going up a little bit, this seemingly violates the math
  1. It would be helpful to have visual markers on the chart, where the points are taken. For example your screenshot has the time going by increments of 10, however your chart draws a grid line every 5 steps. This gives a wrong illusion of what Funman is returning. Having the markers are also very helpful for debugging, and we can turn them off later when things are stable.

Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

@shawnyama shawnyama merged commit 2e0127f into main Oct 2, 2024
4 checks passed
@shawnyama shawnyama deleted the funman-output branch October 2, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT]: funman redesign (output panel)
4 participants