Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transitions & observable tables #5951

Merged
merged 6 commits into from
Jan 3, 2025
Merged

Fix transitions & observable tables #5951

merged 6 commits into from
Jan 3, 2025

Conversation

blanchco
Copy link
Contributor

@blanchco blanchco commented Jan 3, 2025 •
edited
Loading

Description

Address changes that @liunelson wants for the transitions table:

  • removed units from the transitions table
  • use id instead of the template name for transitions
  • show expressions for transitions & observables

@blanchco blanchco self-assigned this Jan 3, 2025
@blanchco blanchco linked an issue Jan 3, 2025 that may be closed by this pull request
[BUG]: The "Transitions" table in the model page are missing the rate laws and have other issues #5919
Closed
3 tasks
@blanchco blanchco marked this pull request as ready for review January 3, 2025 20:13
@blanchco blanchco changed the title Fix transitions table Fix transitions & observable tables Jan 3, 2025
@blanchco blanchco linked an issue Jan 3, 2025 that may be closed by this pull request
[BUG]: The "Observables" table in the model page is missing their math expressions #5921
Closed
2 tasks
@mwdchang
Copy link
Member

mwdchang commented Jan 3, 2025 •
edited
Loading

If what Nelson wanted are not covered by the other bullet points, please elaborate so folks have a better sense of what to look out for.

mwdchang
mwdchang approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@mwdchang mwdchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay!

@mwdchang mwdchang merged commit fca8fba into main Jan 3, 2025
4 checks passed
@mwdchang mwdchang deleted the fix-transitions-table branch January 3, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloppie mloppie mloppie approved these changes

@mwdchang mwdchang mwdchang approved these changes

@shawnyama shawnyama Awaiting requested review from shawnyama shawnyama is a code owner

Assignees

@blanchco blanchco

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@blanchco @mwdchang @mloppie