ranking interventions first pass and better simulation output naming #5969
+110
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawnyama
requested review from
dgauldie,
dvince2,
YohannParis,
mwdchang,
jryu01,
Tom-Szendrey,
blanchco,
asylves1 and
mloppie
as code owners
…A-ASKEM/terarium into start-ranking-interventions
YohannParis
approved these changes
Jan 7, 2025
dvince2
reviewed
Jan 7, 2025
| @@ -345,7 +345,9 @@ public ResponseEntity<Dataset> createFromSimulationResult( | |||
| @PathVariable("id") final UUID id, | |||
| @PathVariable("project-id") final UUID projectId, | |||
| @RequestParam("dataset-name") final String datasetName, | |||
| @RequestParam("add-to-project") final Boolean addToProject | |||
| @RequestParam("add-to-project") final Boolean addToProject, | |||
| @RequestParam("model-configuration-id") final Optional<UUID> modelConfigurationId, | |||
There was a problem hiding this comment.
I don't think Optional is right here, you can just use UUID. If you want to make these params optional it would be done like:
@RequestParam(
value = "model-configuration-id",
required = false
) final String modelConfigurationId,
mwdchang
reviewed
Jan 7, 2025
| @@ -93,6 +93,8 @@ public Dataset createDatasetFromSimulation( | |||
| final String datasetName, | |||
| final UUID projectId, | |||
| final boolean addToProject, | |||
| final Optional<UUID> modelConfigurationId, | |||
| final Optional<UUID> interventionPolicyId, | |||
There was a problem hiding this comment.
Similar to Derek's comment, you don't really need Optionals, just
final UUID modelConfigurationId,
final UUID interventionPolicyId,
you can pass in nulls, Optionals are typically when you programmatically fetch something and you are not sure if you will have a result or not.
Also I think there is already an object-mapper instance in the class you can use, don't need to create a new one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
modelConfigurationIdandinterventionPolicyIdare stored in themetadata.simulationAttributesof datasets resulting from simulations (we will need access to these assets when we rank interventions)