Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transcribe workflow-service to hmi-server - Part 1 #5979

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

mwdchang
Copy link
Member

@mwdchang mwdchang commented Jan 7, 2025

Summary

Workflow updates and syncs can be quirky because we update the workflow object in a wholesale manner. This PR changes the paradigm by telling the server what we want to do to the workflow, rather than doing something to the workflow and asking the server to try to save it.

To not make the PR several thousands lines long, these are left in-place for now and will be done later

  • Cloning a branch in the workflow, this part is very complicated
  • State updates

Added

  • POST /workflow/:id/select-output/:node-id/:output-id
  • POST /workflow/:id/append-output/:node-id
  • POST /workflow/:id/node
  • DELETE /workflow/:id/node/:node-id
  • POST /workflow/:id/edge
  • DELETE /workflow/:id/edge/:edge-id

There are analogous to the functions in client service/workflow.ts

Testing

Normal workflow operations should work as before

@mwdchang mwdchang changed the title Transcribe workflow-service to hmi-server Transcribe workflow-service to hmi-server - Part 1 Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant