Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5965 task compare datasets node thumbnail should be one of the charts #6082

Merged
merged 36 commits into from
Jan 17, 2025
Merged

5965 task compare datasets node thumbnail should be one of the charts #6082

merged 36 commits into from
Jan 17, 2025

Conversation

mloppie
Copy link
Contributor

@mloppie mloppie commented Jan 15, 2025

Description

  • Updates the compare dataset node to show charts
  • Also compare dataset shows a spinner while running, and a placeholder.
  • Adds option to hide a chart from the node in the output settings.
  • New NodeCharts abstraction to contain the logic.
  • Refactor nodes to use the new abstraction and gain the chart hiding feature.
Screenshot 2025-01-15 at 2 24 41 PM Screenshot 2025-01-15 at 3 35 11 PM

Resolves #5960
Resolves #5963
Resolves #5965

@mloppie mloppie linked an issue Jan 15, 2025 that may be closed by this pull request
[TASK]: Compare datasets node thumbnail should be one of the charts #5965
Closed
mloppie and others added 5 commits January 16, 2025 15:14
mloppie and others added 6 commits January 17, 2025 00:37
@mwdchang mwdchang merged commit 254b452 into main Jan 17, 2025
4 checks passed
@mwdchang mwdchang deleted the 5965-task-compare-datasets-node-thumbnail-should-be-one-of-the-charts branch January 17, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnyama shawnyama shawnyama approved these changes

@Tom-Szendrey Tom-Szendrey Tom-Szendrey left review comments

@jryu01 jryu01 jryu01 approved these changes

@mwdchang mwdchang mwdchang left review comments

@YohannParis YohannParis YohannParis left review comments

@blanchco blanchco Awaiting requested review from blanchco blanchco is a code owner

@asylves1 asylves1 Awaiting requested review from asylves1 asylves1 is a code owner

Assignees

@jryu01 jryu01

Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@mloppie @YohannParis @mwdchang @jryu01 @Tom-Szendrey @shawnyama