-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comparison chart settings options for TA3 operator #6112
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ryu-comparison-charts
…ryu-comparison-charts
jryu01
requested review from
YohannParis,
mwdchang,
Tom-Szendrey,
shawnyama,
blanchco,
asylves1 and
mloppie
as code owners
January 17, 2025 00:43
jryu01
changed the title
Comparison charts method for TA3 operator
Comparison chart settings options for TA3 operator
Jan 17, 2025
There are some layout issues with comparison charts in TA3 operator drilldown components and some improvements still need to be made. I'll handle that in a separate PR. |
mwdchang
reviewed
Jan 17, 2025
…ryu-comparison-charts
mwdchang
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't look at the code closely, but overall looks nice!
YohannParis
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
comparison-method-options.mov
Annotations
Resolves #5172