Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparison chart settings options for TA3 operator #6112

Merged
merged 9 commits into from
Jan 17, 2025
Merged

Conversation

jryu01
Copy link
Contributor

@jryu01 jryu01 commented Jan 17, 2025

Description

  • Updated comparison chart settings UI
  • Added an option for sharing same Y axis for small multiples
  • Added an option for show/hide before and after run result
  • Made annotation working
comparison-method-options.mov

Annotations

Screenshot 2025-01-16 at 7 42 09 PM Screenshot 2025-01-16 at 7 42 17 PM

Resolves #5172

@jryu01 jryu01 marked this pull request as ready for review January 17, 2025 00:43
@jryu01 jryu01 changed the title Comparison charts method for TA3 operator Comparison chart settings options for TA3 operator Jan 17, 2025
@jryu01
Copy link
Contributor Author

jryu01 commented Jan 17, 2025

There are some layout issues with comparison charts in TA3 operator drilldown components and some improvements still need to be made. I'll handle that in a separate PR.

Copy link
Member

@mwdchang mwdchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't look at the code closely, but overall looks nice!

@jryu01 jryu01 merged commit fc4318b into main Jan 17, 2025
4 checks passed
@jryu01 jryu01 deleted the jryu-comparison-charts branch January 17, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT]: Comparison charts for TA3 operators
3 participants