Allows conversion of subject data in cases where # AP vs PA fmaps are different after QC filter #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lter by QC to only download pairs that both have QC=1
…flexible if the reformatted fasttrack doesn't filter out QC fail data (and QC fail data is instead filtered out when running aws_downloader)
… based on QC and instead filters based on QC in aws_downloader
…g fmaps that don't specify AP/PA
…s of AP and PA func fmaps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know we are moving away from using the NDA, but I wanted to push my changes in case any last-minute dcm2bids conversions from NDA are needed before the next release is out
I'll be less detailed in my summary as a result, but basically the logic in aws_downloader is updated to accommodate subjects that don't have an even number of AP/PA fmaps for func or dwi data. It reformats the fasttrack WITHOUT filtering for QC in order to use as a reference for correct fmap pairing. The QC filtering now occurs within aws_downloader instead of abcd2bids.py to ensure that only QC-pass (and files marked as complete) are downloaded and converted
I believe at least for func data, this impacted <500 subjects