Change source completeness options; modify source list filters/search by name, source completeness, production method, century #1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests and modify `make_fake_source` to account for source name. Add types to `get_random_search_term`. Refs: DDMAL#1697
Splits the "fragment" and "fragmented" option for Source.source_completeness. Changes the "complete" source option to "complete or mostly complete". Harmonizes word form for production method: "Printed" -> "Print"
…ilters Adds a production method filter to the source list page. Updates the source completeness filter to conform to new source completeness options. Makes it possible to filter by various combinations of source completeness. Adds associated tests.
dchiller
changed the title
dchiller
changed the title
Adds "Fragment" to the Cantus Siglum cells on the source list page, separated by formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a number of changes to the source list page:
The PR also modifies the source completeness field and accompanying filters on the source list page (Closes #1699):
Note: division of "fragment" and "fragmented" sources will have to be a manual process.
Screenshot of source list page (heading area with filters and then scrolled down to see both fragment and non-fragment sources) with these changes: