Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MEIParser to include intervals and contours between neumes & syllables #833

Merged
merged 4 commits into from
Feb 28, 2024

Conversation

dchiller
Copy link
Collaborator

OMR Search enables searching of sequences of intervals and contours both within neumes and between neumes. The version of MEIParser introduced in #806 calculated only intra-neume intervals and contours. This PR adds the calculation of inter-neume intervals and contours to the parser.

This PR also adds some typing to the test suite to conform with --strict checking by mypy and some additional subtests of MEIParser.

Copy link

@jacobdgm jacobdgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the whole, this looks good. I left a couple of suggestions that I think would lead to improved clarity, which are optional, and one question verifying that the code will behave as expected.

@dchiller dchiller merged commit 360c98b into DDMAL:main Feb 28, 2024
2 checks passed
@dchiller dchiller deleted the mei-parser-between-syllable-intervals branch February 28, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants