Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add neume exemplars for omr neume search #915

Merged
merged 4 commits into from
Nov 8, 2024

Conversation

dchiller
Copy link
Collaborator

@dchiller dchiller commented Sep 27, 2024

This PR reintroduces neume exemplars for search. Closes #878. With this, we can also close #796.

This PR:

  • removes the pick_neume_exemplar command and replaces that process with a visual interface for picking neume exemplars. A screenshot of the interface is below.
  • adding an order attribute to neume exemplars so we can have them appear consistently in a consistent order. Also refactors the admin_image property for the neume exemplar (this property defines the url for an image that appears in the admin panel for a neume exemplar -- screenshot below).
  • adds serializers and views for:
    • getting examples of neumes in a source (NeumeSetAPIView)
    • an API endpoint for getting or setting existing neume exemplars in a source (NeumeExemplarsAPIView)
    • a template view to power the interface for picking neume exemplars (PickNeumeExemplarsView)
  • customizes the admin templates for the Django Manuscript model admin to include a link to the interface for picking neume exemplars (see screenshot below)
  • makes adjustments to the frontend for displaying these neume exemplars in the search process (see screenshot below)
  • adds relevant tests for the above

Additionally, removes an unused closing span tag in the base template.

Neume exemplar admin image

image

Interface to pick neume exemplars

image

Link to pick neume exemplars on Manuscript admin page

image

Neume exemplars in the search interface

image

@dchiller dchiller merged commit d2da9e2 into DDMAL:main Nov 8, 2024
2 checks passed
@dchiller dchiller deleted the i878-neume-exemplars branch November 8, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get neume exemplars working Get old MEI search code working on current version of Cantus Ultimus
1 participant