Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #919 Changed 'Treble Voice' button to switch #920

Merged
merged 5 commits into from
Nov 8, 2024
Merged

Issue #919 Changed 'Treble Voice' button to switch #920

merged 5 commits into from
Nov 8, 2024

Conversation

liampond
Copy link
Contributor

'On' state colour is black, same as the page header.

Wasn't sure where the most appropriate place in styles.scss would be for the slider. Put it at the end.

@liampond
Copy link
Contributor Author

Does creating a pull request open a new issue? I forgot to link my commits to issue #919 and only made the reference in my PR. But now it's #920...

@liampond liampond self-assigned this Oct 11, 2024
@dchiller
Copy link
Collaborator

dchiller commented Nov 8, 2024

Wasn't sure where the most appropriate place in styles.scss would be for the slider. Put it at the end.

Yeah, this is fine.

Does creating a pull request open a new issue?

No, but the ID's of issues and PRs are incremented together, so a PR and an issue will never have the same ID.

I forgot to link my commits to issue #919 and only made the reference in my PR. But now it's #920...

If you link issue #919 to this PR under the Development header to the right or use one of these shortcut keywords in the PR description it will link the issue: https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue

@dchiller dchiller linked an issue Nov 8, 2024 that may be closed by this pull request
Change toggleTreble from button to switch (UI) #919
Closed
@dchiller dchiller merged commit 59d2c48 into main Nov 8, 2024
2 checks passed
@dchiller dchiller deleted the button_to_switch branch November 8, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchiller dchiller dchiller approved these changes

Assignees

@liampond liampond

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change toggleTreble from button to switch (UI)
2 participants
@liampond @dchiller