Fix memory issues #185
Open
Fix memory issues #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of doing so in all invocations and allocating a new array.
- fixes a memory leak - prepare for further fixes: change TTYMUX_GET_SESSIONS to return list instead of modifying HostNode->screens, so it can be used in places that expect HostNode->screens not to change
…used by the UI Still fetch session list, but only use it to check if session is alive; don't store it.
also use xmlResetLastError instead of xmlResetError, as the latter wants a non-const pointer, but xmlGetLastError returns a const one.
|
Unrelated, but as it seems you're currently preparing a new release:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
another couple of memory related patches.
I think the fix for the "use after free" is the most important one (i think this was the main reason my apt-dater kept crashing, and the reason I started to look into the source).