Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recording: add clip only if information exists #130

Merged
merged 3 commits into from
Jul 3, 2024
Merged

recording: add clip only if information exists #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7387235
recording: add clip only if information exists
PhilippKilian May 31, 2024
1910e98
changelog: add 3.2.5 information
PhilippKilian May 31, 2024
aa5b6d0
CHANGELOG.md: fix typo
PhilippKilian Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# ChangeLog

# 3.2.5 - 2024-07-03

Fixes:
- missing check for no clips during rendering task

## 3.2.4 - 2024-06-16

Fixes:
Expand Down
14 changes: 8 additions & 6 deletions b3lb/rest/b3lb/make_xges.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,12 +260,14 @@ def add_slides(self):

# Find the width/height of the slide corresponding to this
# point in time
info = [i.data for i in slide_time.at(pos.start)][0]
width, height = self._constrain(
(info.width, info.height),
(self.slides_width, self.opts.height))

self._add_clip(cursor_layer, dot, pos.start, 0, end - pos.start, round(width*pos.x - dot_width/2), round(height*pos.y - dot_height / 2), dot_width, dot_height)
info_list = [i.data for i in slide_time.at(pos.start)]
if info_list:
info = info_list[0]
width, height = self._constrain(
(info.width, info.height),
(self.slides_width, self.opts.height))

self._add_clip(cursor_layer, dot, pos.start, 0, end - pos.start, round(width*pos.x - dot_width/2), round(height*pos.y - dot_height / 2), dot_width, dot_height)

layer = self._add_layer('Annotations')
# Move above the slides layer
Expand Down
Loading