Revision date in list & edit intended start date #570
Conversation
There was a problem hiding this comment.
I didn't test it locally, but I don't see anything would warrant a local test assuming you did test your code ;)
2 textual changes I'd like to see. The other two comments are niceties, I'm fine with as they are now if you don't think the niceties are required
| {% blocktrans trimmed with title=proposal.title ref_number=proposal.reference_number %} | ||
| Op deze pagina kan de startdatum worden aangepast van de aanvraag {{ title }} | ||
| (referentienummer <em>{{ ref_number }}</em>). <b>Let op!</b> Als de review al is afgerond, | ||
| wordt de nieuwe startdatum niet automatisch weergegeven in de PDF. Mocht u de PDF |
| <p> | ||
| {% trans "Vul de datum in als 'DD-MM-YYYY'." %} | ||
| </p> |
There was a problem hiding this comment.
This is incorrect.
It might work, it will probably work when the locale is set to Dutch, but it might not always.
YYYY-MM-DD will always work
Or... Just use the custom year widget?
There was a problem hiding this comment.
I added the DateField widget from cdh core
| {# For some reason context.review.REVISION and other class variables of continuation are None?#} | ||
| {# Only context.review.GO returns 0 for me, as it should #} | ||
| {# Which is why I've hardcoded the 1 here ... #} |
There was a problem hiding this comment.
I can answer this one for you. This is a Vue template (and a first-generation one, which is a bit crap compared to what we're migrating to).
Thus, the context used here is not the same as what you'd expect. It's a manually created dict in reviews/api/views.py.
GO is in the dict; REVISION isn't. If you add it to the dict, you can reference it here.
| if is_secretary(user): | ||
| pdf_container.date_start_edit_link = reverse('proposals:update_date_start', | ||
| args=[proposal.pk]) |
There was a problem hiding this comment.
I don't really like adding this link to the document list code. You're not updating documents.
This should be a review action instead, I think.
There was a problem hiding this comment.
I agree that does make more sense! fixed
Fixes for issues #512 and #483. Just some niceties for Desiree. I'd say these work fine :)