Low hanging fruit mass-PR #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #430 Okay not really a refactor, but honestly none of the other tags really fit
tymees
added
the
Settings change
Thanks Github for reminding me! ;)
EdoStorm96
approved these changes
Nov 13, 2023
miggol
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Nice work. I appreciate the cleanup of the menu file as well, that one tripped me up once or twice.
Went through all text and translations and ran through a dev environment with no issues.
Somehow I'm a little surprised that deleting an app does not generate a migration. Guess those tables will just linger. Fine by me.
# Conflicts: # locale/en/LC_MESSAGES/django.mo # locale/en/LC_MESSAGES/django.po
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #430 #514 #549 #550 #554 and a bonus non-issue unused template removal
Basically, all low hanging fruit aside from #529 as Desiree is still OOO. (I wanted something simple to do for once lol)
As they were all 5-min fixes I didn't really feel like creating separate PR's for them, but I did solve all issues in their own commit.
The only real big impact is the removal of feedback; the deploy script needs to be updated to not try to load the now missing app.
It would be nice if this could be merged at the same time as #573, as that needs deploy script changes as well. As for the content: they are pretty simple, but as always I'd like a double check of my english