-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge 'develop' into 'acceptation' #651
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* deps: Update dependencies * fix: Update dependencies with a modern version of pip-tools * deps: added sentry-sdk --------- Co-authored-by: Tyler Mees <[email protected]>
* fix: correct 'start of proposal' redirect for pre_approved * fix: improve buttons on proposal_confirmation.html * fix: diff bugfix * fix: buttons on task and session delete * fix: formatting * Revert 'confirmation sent' text on button back to past tense * Hotfix/to conclude review api view qs bug (#629) * fix: add is_committee_review check to ToConcludeReviewApiView qs * fix: add is_committee_review check to other API views * formatting --------- Co-authored-by: Ty Mees <[email protected]> * feat: is_final_decision method on Decision model * feat: Warning when submitting a final decision * fix: A capital letter * fix: Show decide review action when already decided * feat: translations * fix: Some fuzzy or missing translations * feat: Turn final deicision warning into alert box * fix: Same translation somehow needed fixing again... * feat: Alternate action description for feedback editing --------- Co-authored-by: Edo Storm <[email protected]> Co-authored-by: Edo Storm <[email protected]> Co-authored-by: Ty Mees <[email protected]>
…d_textual_changes Fix/bugfix and textual changes
…_decide_on_detail_view Feat/supervisor decide on detail view
…xt_informed_consent feat: add help text to Documents.informed_consent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I´d like to deploy some fixes for some small issues. These are mostly textual. The only fix which has a slightly significant impact is the fix for #638. Otherwise these are just a bunch of textual changes and layout changes, with no real impact on functionality.