Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update master from Acceptation #714

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Update master from Acceptation #714

merged 4 commits into from
Oct 10, 2024

Conversation

miggol
Copy link
Contributor

@miggol miggol commented Oct 8, 2024

To be merged after #713

Turns out there was still a feature hanging out in Acc ready for deployment.

@miggol miggol requested a review from EdoStorm96 October 8, 2024 14:44
Copy link
Contributor

@EdoStorm96 EdoStorm96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some minor minor issues ... But imo fixing this should not be a priority. I say deploy :)

msgstr ""
"If that is the case, you can still use the portal. If you have any "
"questions, you can contact <a href=\"mailto:portalsupport.gw@uu."
"nl\">[email protected]</a>"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really care ... but the English translation does not end with a period.

"href=\"https://utrechtuniversity.github.io/dataprivacyhandbook/\">Data "
"Privacy Handboek</a> te raadplegen."
"href=\"https://utrechtuniversity.github.io/dataprivacyhandbook/\" "
"target=\"_blank\">Data Privacy Handboek</a> te raadplegen."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These translations seem to not be updated ... But imho this is not a huge deal.

@miggol miggol merged commit ebe71b2 into master Oct 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants