Remove retina endpoints #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests on main are likely broken. |
HarmvZ
requested changes
Jan 24, 2024
Co-authored-by: Harm van Zeeland <[email protected]>
|
@jmsmkn I just came across this. Do you know what is going on with the failing tests? |
|
Likely something with the GC fixtures changed and the tests broke. They should be re-run on main. If so, it is not ideal to rely on those fixtures kept on GC. Maybe we should create the fixtures that are needed for the GCAPI tests within this repo. |
|
I'm not sure if this PR works, I think it's better to fix the tests on main first then merge/rebase. |
|
Sidenote: Some references to retina stuff are still in the models.py file. This will automatically be removed when we regenerate the file. |
Merged
Two tests have been removed: - `test_update_interface_kind_of_archive_item_image_civ` - `test_create_job_with_upload` They will need to be added back later. Co-authored-by: James Meakin <[email protected]>
2 tasks
chrisvanrun
pushed a commit
that referenced
this pull request
Nov 5, 2024
See DIAGNijmegen/rse-grand-challenge-admin#236 --------- Co-authored-by: Harm van Zeeland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/DIAGNijmegen/rse-grand-challenge-admin/issues/236