-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 3 #19
Issue 3 #19
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DaevMithran do refactor all script file under src/main/bash folder ,
Other suggested refactoring are:.
- Move core and common VCR handling script to helper, Github/Gitlab specific capabilies would reside in the respective plugins.
- Introduce a capablity to include plugins in the corresponding folder structure post install of DRman. This can also happen later using DRman command/script to install xxx plugin
- Group multiple function signatures i.e for create, delete , validate, reset etc for a XXX VCR in a single xxx-plugin script.
- Create the common DRman plugin template with generic functions like create, delete, validate, reset etc.
@panickervinod sound's good. Will work on it |
Signed-off-by: DaevMithran <[email protected]>
Signed-off-by: DaevMithran <[email protected]>
@panickervinod can we merge the current code? I'll create separate pull requests for further developments. |
Code changes
|
@DaevMithran Please can you also fix the naming convention for the function names . |
To raise a new Pull Request, the following prerequisites need to be met. Please tick before proceeding:
The current code
- with an admin folder
- where the creator's DID folder is created