Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3 #19

Closed
wants to merge 6 commits into from
Closed

Issue 3 #19

wants to merge 6 commits into from

Conversation

DaevMithran
Copy link
Collaborator

@DaevMithran DaevMithran commented Jun 23, 2022

To raise a new Pull Request, the following prerequisites need to be met. Please tick before proceeding:

The current code

  • creates an organization if it doesn't exists
  • creates a repository
  • added branch and signature protections for the repository
  • commits a genesis transaction
    - with an admin folder
    - where the creator's DID folder is created

Copy link
Collaborator

@panickervinod panickervinod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DaevMithran do refactor all script file under src/main/bash folder ,

Other suggested refactoring are:.

  1. Move core and common VCR handling script to helper, Github/Gitlab specific capabilies would reside in the respective plugins.
  2. Introduce a capablity to include plugins in the corresponding folder structure post install of DRman. This can also happen later using DRman command/script to install xxx plugin
  3. Group multiple function signatures i.e for create, delete , validate, reset etc for a XXX VCR in a single xxx-plugin script.
  4. Create the common DRman plugin template with generic functions like create, delete, validate, reset etc.

@DaevMithran
Copy link
Collaborator Author

@panickervinod sound's good. Will work on it

@DaevMithran
Copy link
Collaborator Author

@panickervinod can we merge the current code? I'll create separate pull requests for further developments.

@DaevMithran
Copy link
Collaborator Author

Code changes

  • Creates an admin and member teams when are repository is created by default e.g. REPONAME_ADMIN, REPONAME_MEMBER
  • Added feature to resolve a DID

@panickervinod
Copy link
Collaborator

panickervinod commented Aug 11, 2022

@DaevMithran Please can you also fix the naming convention for the function names .
i.e the function names have a prefix of "_drm" @arunprakashpj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants