Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add DID and GithubVCR plugins #21

Merged
merged 11 commits into from
Nov 11, 2022
Merged

Conversation

DaevMithran
Copy link
Collaborator

@DaevMithran DaevMithran commented Nov 11, 2022

To raise a new Pull Request, the following prerequisites need to be met. Please tick before proceeding:

  • a conversation was held in the appropriate DRMAN Slack channel.
  • a Github Issue was opened for this feature / bug.
  • Move helper scripts inside src/plugins folder
  • Prepend exported variables with DRM_
  • Add githubVCR plugin with Orgs, Repos, Team management scripts
  • Add DID plugins with Create/Update/Resolve scripts

This addresses Issue #3 Issue #4 Issue #5 Issue #6

@DaevMithran DaevMithran requested review from panickervinod, arunprakashpj and Sarvesh67 and removed request for panickervinod November 11, 2022 05:44
@@ -10,6 +10,8 @@ plugins {
String userHome = System.getProperty('user.home')
ext.installBinDir = "${userHome}/.drman/bin"
ext.installSrcDir = "${userHome}/.drman/src"
ext.installHelperDir = "${userHome}/.drman/helper"
Copy link
Collaborator

@panickervinod panickervinod Nov 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider moving helpers under src/main/bash..

@panickervinod panickervinod merged commit 031cb8e into DIDman:master Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants