add dke:ping #138
Merged
add dke:ping #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test output helper was not being utilized in the PingServiceTest class and has been removed to clean up the code. Additionally, a minor spacing adjustment was made in the existing Fact attribute for consistency.
Simplify variable declaration from explicit type to 'var' in PingServiceTest. This change promotes readability and adheres to modern C# coding conventions.
Clarify the reason for skipping the PingServiceTest fact. The updated message highlights that a deleted endpoint cannot be automatically tested and requires manual actions.
Updated PingServiceTest.cs to refactor a test method for better readability. Changed variable declaration and initialization style for consistency. Kept skip attribute message format consistent across tests.
Removed unused using directives in PingServiceTest.cs to clean up the code. This helps improve readability and maintainability by excluding unnecessary dependencies.
Eliminated an unnecessary import statement for `Agrirouter.Feed.Request` in PingService.cs to clean up the code. This change helps in maintaining clarity and avoiding potential confusion with unused references.
|
@oliverrahner please check the minor adjustments and leave a short comment if that's fine. |
|
Thanks for the cleanup :) |
saschadoemer
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.