Feature/update mqtt3 to mqtt4 #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit upgrades the MQTTnet package from version 3.0.9 to 4.3.6.1152 in both the main API project and the test project. This update is intended to leverage new features and improvements in the latest version of MQTTnet.
Refactor MQTT message handling to use the ApplicationMessageReceivedAsync event instead of UseApplicationMessageReceivedHandler. This aligns with updated MQTTnet library practices and ensures better async event handling. Removed the unnecessary MQTTnet.Client import.
Switched from MQTTnet.Client.Publishing to MQTTnet.Client to resolve namespace discrepancies and ensure compatibility with updated library versions.
Replaced deprecated `.WithCommunicationTimeout()` method with `.WithTimeout()` for setting MQTT communication timeout. Removed unused `MQTTnet.Client.Options` import statement for cleanup.
Refactor the MQTT message publishing process by switching to the appropriate MQTTnet.Protocol namespace and improving code readability. Utilize the `MqttQualityOfServiceLevel.ExactlyOnce` for enhanced clarity and ensure proper formatting and spacing throughout.
Updated the application message handling in PingServiceTest to use the asynchronous event handler. This ensures better responsiveness and non-blocking execution while verifying response codes in the unit tests.
|
@oliverrahner since the interface is still stable, I would just bump to the next minor version? |
|
Agreed! |
alessandroros
approved these changes
Aug 21, 2024
|
@Frank-Wiebeler could you add a review? |
oliverrahner
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.