-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/update file structure to match other sdks #51
Feature/update file structure to match other sdks #51
Commits on May 2, 2024
-
Update import and rename constants file
The import statement in mqtt.py was updated to reference the correct file for SYNC and ASYNC constants. Additionally, the constants.py file was renamed to mqtt_connection_mode.py, providing a more accurate description of its content.
Configuration menu - View commit details
-
Copy full SHA for 6e6f756 - Browse repository at this point
Copy the full SHA 6e6f756View commit details -
Refactor certificate creation to CertificationService class
The certificate creation code has been encapsulated into a new class, CertificationService. This allows for a more organized codebase, increasing the readability and maintainability of the code. This change impacts the methods in the http.py and mqtt.py files where the create_certificate_file_from_pen function call is replaced by CertificationService.create_certificate_file_from_pen.
Configuration menu - View commit details
-
Copy full SHA for cb7b29e - Browse repository at this point
Copy the full SHA cb7b29eView commit details -
Refactor decoding methods into DecodingService class
Moved `decode_response`, `read_properties_buffers_from_input_stream` methods into a new DecodingService class as static methods. Updated all their usages across the codebase to reflect this change. This consolidation streamlines code organization and enhances readability.
Configuration menu - View commit details
-
Copy full SHA for 93d16c7 - Browse repository at this point
Copy the full SHA 93d16c7View commit details -
Refactor decoding functions into DecodingService class
The decoding functions `decode_response` and `decode_details` have been refactored into static methods in the `DecodingService` class in `src/agrirouter/messaging/decode.py`. The changes also involved updating the relative imports in test files and other modules that were previously using these standalone functions.
Configuration menu - View commit details
-
Copy full SHA for 3667358 - Browse repository at this point
Copy the full SHA 3667358View commit details -
Refactor encoding functions into EncodingService class
The encoding functions previously contained within the file `encode.py` are refactored into a new class called `EncodingService`. This improves the organization of the code and makes it easier to manage and understand. All corresponding tests and imports have been updated to use this new class.
Configuration menu - View commit details
-
Copy full SHA for e15a9b6 - Browse repository at this point
Copy the full SHA e15a9b6View commit details -
Refactor encoding functions into EncodingService class
The standalone encode and write_proto_parts_to_buffer functions have been refactored into a static methods inside the newly created EncodingService class. All instances where these functions were called have been updated to use this new class method. This enhances the code structure and makes it more organized.
Configuration menu - View commit details
-
Copy full SHA for 721d9ea - Browse repository at this point
Copy the full SHA 721d9eaView commit details -
Moved CertificateTypes and Gateways enum to api.enums
The enum classes, CertificateTypes and Gateways, previously located under onboarding.enums, have been moved to api.enums. The import statements in the impacted files have been adjusted accordingly. This ensures a more logical arrangement of the enum information and simplifies future maintenance.
Configuration menu - View commit details
-
Copy full SHA for ca93168 - Browse repository at this point
Copy the full SHA ca93168View commit details -
Refactor signature handling into SignatureService class
The handling of signature creation and verification has been refactored into a new SignatureService class. This change has improved modularity and allowed signature-related functions to be called directly from the service. This commit involves changes to the agrirouter.onboarding, agrirouter.auth, and agrirouter.revoking modules, plus updates to relevant tests.
Configuration menu - View commit details
-
Copy full SHA for f504f7f - Browse repository at this point
Copy the full SHA f504f7fView commit details -
Refactored utc_time_util to a class structure
The utc_time_util functions have been adjusted into a class structure for improved organization and code readability. This also involves changes to the function calls in several source files where these functions were used.
Configuration menu - View commit details
-
Copy full SHA for caf9202 - Browse repository at this point
Copy the full SHA caf9202View commit details -
Refactor uuid utility to a class-based implementation
The refactor includes changing the direct function calls of 'new_uuid()' to the class-based static method 'UUIDUtil.new_uuid()'. These changes impact multiple files across the application, improving the overall structure following the object-oriented programming paradigm.
Configuration menu - View commit details
-
Copy full SHA for 87594bb - Browse repository at this point
Copy the full SHA 87594bbView commit details -
Refactor environment handling and file structure
The 'environments.py' file was renamed to 'env.py' and EnvironmentService class is now inside 'api/env.py'. References to the old file structure were updated accordingly across multiple modules to ensure correct importing. The 'environmental_services.py' was deleted after moving its content to 'env.py'.
Configuration menu - View commit details
-
Copy full SHA for d9c66c3 - Browse repository at this point
Copy the full SHA d9c66c3View commit details -
Refactor constants and keys management in agrirouter API
This commit consolidates the handling of constants and keys within the agrirouter API. The 'mqtt_connection_mode.py' file has been deleted, and its ASYNC/SYNC constants moved into the '#constants.py' file. References to these keys and constants across the API have been updated to reflect the changes.
Configuration menu - View commit details
-
Copy full SHA for 26a3f7d - Browse repository at this point
Copy the full SHA 26a3f7dView commit details -
Refactored package structure and rearranged onboarding and messaging …
…components. The package structure has been rearranged to improve code organization. The agrirouter 'onboarding' and 'messaging' modules were moved into a new 'service' module. As part of this reorganization, various code files were renamed and moved to new locations. This refactoring enhances the structure of the code and makes it easier to navigate and maintain. The naming and organization of components are now more logical, reflecting their associated responsibilities.
Configuration menu - View commit details
-
Copy full SHA for ef38123 - Browse repository at this point
Copy the full SHA ef38123View commit details -
Update efdi_pb2.py in agrirouter messaging
The protobuf file for agrirouter messaging, efdi_pb2.py, has been updated by removing unnecessary white spaces and a few unused import statements. File descriptor parameters have also been revised to enhance the efficiency and readability of the code.
Configuration menu - View commit details
-
Copy full SHA for c2d7e1e - Browse repository at this point
Copy the full SHA c2d7e1eView commit details -
Refactor import statements across multiple modules
The import statements in several modules have been refactored for better organization and clarity. Reorganization ensures relevant modules/classes are logically grouped together, improving code readability and maintainability.
Configuration menu - View commit details
-
Copy full SHA for 7251045 - Browse repository at this point
Copy the full SHA 7251045View commit details -
Refactor import order in test modules
Cleaned up the order of imports in various test modules. This process specifically prioritizes standard library imports, followed by related third party imports, and local application/library specific imports.
Configuration menu - View commit details
-
Copy full SHA for 0263758 - Browse repository at this point
Copy the full SHA 0263758View commit details -
Refactor messaging services and minor changes in file structures
Made several changes in messaging services including restructuring and moving certain classes to align with design patterns. Also made minor changes and updates in file structures of various test scripts and source files. Improved unified decoding strategy with EncodingService class.
Configuration menu - View commit details
-
Copy full SHA for dadbcb1 - Browse repository at this point
Copy the full SHA dadbcb1View commit details