Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

judgeenv: properly specify a default in docker #1027

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Riolku
Copy link
Contributor

@Riolku Riolku commented Mar 22, 2022

What we probably want to do here is have a default when we are in docker. Right now, if the model_file exists, the default is completely ignored.

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2022

Codecov Report

Merging #1027 (11ac821) into master (9551b06) will increase coverage by 2.98%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1027      +/-   ##
==========================================
+ Coverage   81.24%   84.23%   +2.98%     
==========================================
  Files         140      140              
  Lines        4789     4789              
==========================================
+ Hits         3891     4034     +143     
+ Misses        898      755     -143     
Impacted Files Coverage Δ
dmoj/judgeenv.py 56.84% <ø> (ø)
dmoj/judge.py 53.98% <0.00%> (+1.22%) ⬆️
dmoj/executors/java_executor.py 86.36% <0.00%> (+3.03%) ⬆️
dmoj/cptbox/compiler_isolate.py 55.31% <0.00%> (+6.38%) ⬆️
dmoj/cptbox/tracer.py 76.32% <0.00%> (+18.02%) ⬆️
dmoj/cptbox/handlers.py 100.00% <0.00%> (+26.31%) ⬆️
dmoj/cptbox/isolate.py 89.63% <0.00%> (+38.41%) ⬆️
dmoj/control.py 100.00% <0.00%> (+64.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9551b06...11ac821. Read the comment docs.

What we probably want to do here is have a default when we are in docker. Right now, if the model_file exists, the default is completely ignored.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants