-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change regex to filesystem policy matcher, first step of #871 #873
Conversation
Can one of the admins verify this patch? |
ok to test |
Codecov Report
@@ Coverage Diff @@
## master #873 +/- ##
==========================================
+ Coverage 85.51% 85.84% +0.33%
==========================================
Files 135 137 +2
Lines 4466 4599 +133
==========================================
+ Hits 3819 3948 +129
- Misses 647 651 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will take another look tmr...
Java doesn't self-test properly, complaining about a Protection Fault on sys_fchdir, which is surprising, to say the least. The other tests pass though. I'm still unsure what to do about |
Also, the flake8 issue is not resolved. Not sure what to do there either. |
Temporary solution: ignore the local flake8 errors when you know they are wrong. |
I get E302 locally, but I see no ignore rule in |
E302 is for spacing between functions. Something must really be messed up. Do you have line-ending issues? |
I don't think so? |
Then something is really messed up with your flake8 setup. What's the python version? Where are you running flake8? The code as it currently is is not mergable. You have so many excessive new lines in your code that it hurts my eyes to read. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good!
e7cf629
to
e24b01d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems legit. Good job!
Waiting on #872, and approval |
Hmm, but #872 has already been merged...? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM, thanks for working on this.
3337814
to
4606b58
Compare
ran |
c97e543
to
93ad9f5
Compare
Just realized I have a ton of quote issues, thanks to |
f1934f8
to
ce5cd07
Compare
Simply rebasing after #887 |
c53f247
to
940fba3
Compare
Notably, this is no longer at all true. A trie implementation was taken instead. |
This is the first step of migrating to Landlock support. A very simplistic implementation is given here.