Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comment revision count #2330

Merged
merged 1 commit into from
May 26, 2024
Merged

Fix comment revision count #2330

merged 1 commit into from
May 26, 2024

Conversation

int-y1
Copy link
Contributor

@int-y1 int-y1 commented Apr 12, 2024

Fixes #2295. This fixes all comments created since #2216.

When a comment is created, the comment is on the first revision. So the default value of revisions should be 1.

Migration 0146 is a copy of 0142, except for the AlterField operation.

Screenshots

Stay on the old code. Make a comment with 3 edits: Screenshot 2024-04-11 205130

Go to the new code and run migration. Make a comment with 5 edits: Screenshot 2024-04-11 205412

Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@Xyene Xyene added this pull request to the merge queue May 26, 2024
Merged via the queue into DMOJ:master with commit d2e9fac May 26, 2024
3 checks passed
@int-y1 int-y1 deleted the fix-comment-revisions branch May 26, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix off-by-1 error in comment revisions
2 participants