Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: add submission filtering by contest + contest info #2337

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

Xyene
Copy link
Member

@Xyene Xyene commented May 25, 2024

No description provided.

@Xyene Xyene force-pushed the submission-api-improvements-for-contests branch from da5e387 to a0e57c0 Compare May 25, 2024 16:26
Copy link
Member

@Ninjaclasher Ninjaclasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before:

SELECT
    `judge_submission`.`id`,
    `judge_submission`.`user_id`,
    `judge_submission`.`problem_id`,
    `judge_submission`.`date`,
    `judge_submission`.`time`,
    `judge_submission`.`memory`,
    `judge_submission`.`points`,
    `judge_submission`.`language_id`,
    `judge_submission`.`result`,
    `judge_submission`.`contest_object_id`,
    `judge_profile`.`id`,
    `judge_profile`.`user_id`,
    `auth_user`.`id`,
    `auth_user`.`username`,
    `judge_problem`.`id`,
    `judge_problem`.`code`,
    `judge_language`.`id`,
    `judge_language`.`key`,
    `judge_contestsubmission`.`id`,
    `judge_contestsubmission`.`participation_id`,
    `judge_contestsubmission`.`points`
...

After:

SELECT `judge_submission`.`id`,
    `judge_submission`.`user_id`,
    `judge_submission`.`problem_id`,
    `judge_submission`.`date`,
    `judge_submission`.`time`,
    `judge_submission`.`memory`,
    `judge_submission`.`points`,
    `judge_submission`.`language_id`,
    `judge_submission`.`result`,
    `judge_submission`.`contest_object_id`,
    `judge_profile`.`id`,
    `judge_profile`.`user_id`,
    `auth_user`.`id`,
    `auth_user`.`username`,
    `judge_problem`.`id`,
    `judge_problem`.`code`,
    `judge_language`.`id`,
    `judge_language`.`key`,
    `judge_contest`.`id`,
    `judge_contest`.`key`,
    `judge_contestsubmission`.`id`,
    `judge_contestsubmission`.`participation_id`,
    `judge_contestsubmission`.`points`,
    `judge_contestparticipation`.`id`,
    `judge_contestparticipation`.`start`,
    `judge_contestparticipation`.`virtual`
...

judge/views/api/api_v2.py Outdated Show resolved Hide resolved
judge/views/api/api_v2.py Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 46.78%. Comparing base (356b146) to head (4f0878c).
Report is 29 commits behind head on master.

Files Patch % Lines
judge/views/api/api_v2.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2337      +/-   ##
==========================================
- Coverage   46.84%   46.78%   -0.07%     
==========================================
  Files         250      252       +2     
  Lines       13275    13348      +73     
==========================================
+ Hits         6219     6245      +26     
- Misses       7056     7103      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Xyene Xyene force-pushed the submission-api-improvements-for-contests branch from 4cce747 to a0e57c0 Compare June 1, 2024 18:55
@Xyene Xyene requested a review from Ninjaclasher June 1, 2024 18:56
@Xyene Xyene force-pushed the submission-api-improvements-for-contests branch from a0e57c0 to 4f0878c Compare June 2, 2024 05:41
Copy link
Member

@Ninjaclasher Ninjaclasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xyene Xyene added this pull request to the merge queue Jun 2, 2024
Merged via the queue into DMOJ:master with commit d6a3ff3 Jun 2, 2024
3 checks passed
@Xyene Xyene deleted the submission-api-improvements-for-contests branch June 2, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants