Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning when posting code to comments #2343

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

int-y1
Copy link
Contributor

@int-y1 int-y1 commented May 28, 2024

cleaned-up version of VNOI-Admin/OJ#201

Screenshot 2024-05-27 231527

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.78%. Comparing base (fd7fb05) to head (c3d0cab).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2343      +/-   ##
==========================================
+ Coverage   46.76%   46.78%   +0.01%     
==========================================
  Files         251      252       +1     
  Lines       13317    13348      +31     
==========================================
+ Hits         6228     6245      +17     
- Misses       7089     7103      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ninjaclasher
Copy link
Member

I think this code is also used for contest / blog post comments. Maybe we want a different message there since redirecting to the "submit solution" button is no longer meaningful.

@int-y1
Copy link
Contributor Author

int-y1 commented Jun 5, 2024

list of changes:

  • popup message changed. "post a source code" -> "post some source code"
  • popup only appears on /problem/<problem code>. all other comment sections still work, and aren't affected.

@int-y1 int-y1 requested a review from Ninjaclasher June 5, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants