Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test case explanation #2345

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

FherStk
Copy link
Contributor

@FherStk FherStk commented Aug 18, 2024

Prerequisite: this PR will remain as a draft till the acceptance of #2305

Additions:
Optional explanation files can now be added to a problem's test-cases:
imagen

If added, the information will be rendered after the output information if the 'include test-cases' option has been selected at problem settings. Notice that also the test-cases information has rearranged in order to improve the readability:
imagen

Also, the YML file will be updated consequently, because the PR #2305 includes the ability to infer or rebuild the data using an existing YML file from the problem's folder on the file system:
imagen

Cheers!
Fher

…lso able to hide test-cases from the problem statement respecting the judge order (pretest firsts).

fixes
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2024

Codecov Report

Attention: Patch coverage is 12.27273% with 193 lines in your changes missing coverage. Please review.

Project coverage is 46.25%. Comparing base (fd7fb05) to head (bcdcf85).
Report is 15 commits behind head on master.

Files Patch % Lines
judge/models/problem_data.py 7.74% 143 Missing ⚠️
judge/views/problem_data.py 9.37% 29 Missing ⚠️
judge/utils/problem_data.py 0.00% 10 Missing ⚠️
judge/views/problem.py 0.00% 6 Missing ⚠️
judge/models/problem.py 37.50% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2345      +/-   ##
==========================================
- Coverage   46.76%   46.25%   -0.51%     
==========================================
  Files         251      254       +3     
  Lines       13317    13563     +246     
==========================================
+ Hits         6228     6274      +46     
- Misses       7089     7289     +200     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FherStk FherStk force-pushed the test-case-explanation branch 3 times, most recently from a3a4763 to bcdcf85 Compare August 18, 2024 10:05
…ings, the data included in the 'xpl' file will be displayed at the problem statement after its related output.

The test-case information on the problem statement has been arranged by test-cases in order to make it more readable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants