Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IIS Issue 516 #667

Closed
wants to merge 13 commits into from
Closed

Conversation

SmallMistake
Copy link
Contributor

This pull request fulfills the three requests outlined in this issue:
#516

  1. Update the IIS Image
  2. Include a note saying to use App Pool over Network Service
  3. Include a note saying to not increase the number of workers on an App Pool

As for the first one about the IIS Image being out of date, it seems that the one currently up is almost identical to my IIS 10 structure. So. it might have already been updated. If it has been, feel free to revert it back to the old image if you want to keep the photoshopped elements the same as before.

Copy link
Member

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the image here is probably a drag-and-drop into github, this will not work on the published site, an image needs to be actually part of the repository and then a relative link needs to be made to it like it was before this change

@SmallMistake
Copy link
Contributor Author

Okay, let me change that on all the pull requests I have just submitted. I did not notice that there was a difference.

Copy link
Member

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to also update the link to point to the right image

@@ -37,7 +37,7 @@ links: ["[DNN Wiki: Setting up Your Module Development Environment](https://www.



![IIS options to turn on](/images/scr-InstallIIS-6.png)
![IISUpdated](https://user-images.githubusercontent.com/44900498/157516146-f7cb1f9d-058f-48d4-86bc-983eaa7897ab.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great but this link need to point to the image now :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I fixed the problem I was having due to saving the image in the wrong file. That should be all of them, but I'll double check just to be sure.

@SmallMistake
Copy link
Contributor Author

Wait, now I have to fix that problem of the Localization branch being merged in. I'll fix that in a sec.

@SmallMistake
Copy link
Contributor Author

Everything has gone haywire on this branch due to it getting merged with the others and then it got worse locally. I'll just close the pull request and start fresh after the others have gone through.

@SmallMistake SmallMistake deleted the IISIssue516 branch March 9, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants