Added definitionName in the moduleDefinitions section #725
Conversation
Added definitionName to the moduleDefinition section. This can be different from the friendly name.
Update index.md
|
@MaiklT thanks for the contribution. It appears there is more in this PR that the title and description suggest. Can you remove the unrelated commits so we can merge this? Thanks! |
There was a problem hiding this comment.
This doesn't appear to be related to the manifest.
There was a problem hiding this comment.
I could delete this file from the pull request, but have issues with removing the images.
There was a problem hiding this comment.
This doesn't appear to be related to the manifest.
There was a problem hiding this comment.
You are right. Please delete this file from the pull request, I always get the Message "Unable to render rich display" and the "Delete file" option is grayed out.
There was a problem hiding this comment.
I don't think we can delete those in the browser (no way I can see)...
Ideally it makes it easier to work on dedicated branches to submit PRs than from main/master/develop
There was a problem hiding this comment.
This doesn't appear to be related to the manifest.
There was a problem hiding this comment.
You are right. Please delete this file from the pull request, I always get the Message "Unable to render rich display" and the "Delete file" option is grayed out.
There was a problem hiding this comment.
@MaiklT I will just respond to this comment, but the same applies to most of the requests for us to delete your files. We cannot delate files on your branch, as we do not have the necessary permission to do so.
It would be best for you to do the following:
- Sync your forked repo with this one.
- Create a branch off of your forked
mainbranch and name it as something likedefinition-name. - Implement only the proposed change.
- Submit a new PR from your
definition-namebranch to the upstreammain.
Let us know if you decide to go this route and we can simply close this PR. Thanks.
There was a problem hiding this comment.
This doesn't appear to be related to the manifest.
There was a problem hiding this comment.
You are right. Please delete this file from the pull request, I always get the Message "Unable to render rich display" and the "Delete file" option is grayed out.
There was a problem hiding this comment.
This doesn't appear to be related to the manifest.
There was a problem hiding this comment.
You are right. Please delete this file from the pull request, I always get the Message "Unable to render rich display" and the "Delete file" option is grayed out.
There was a problem hiding this comment.
This doesn't appear to be related to the manifest.
There was a problem hiding this comment.
You are right. Please delete this file from the pull request, I always get the Message "Unable to render rich display" and the "Delete file" option is grayed out.
There was a problem hiding this comment.
This doesn't appear to be related to the manifest.
There was a problem hiding this comment.
You are right. Please delete this file from the pull request, I always get the Message "Unable to render rich display" and the "Delete file" option is grayed out.
There was a problem hiding this comment.
This doesn't appear to be related to the manifest.
There was a problem hiding this comment.
You are right. Please delete this file from the pull request, I always get the Message "Unable to render rich display" and the "Delete file" option is grayed out.
The documentation of the manifest is missing the definitionName in the moduleDefinitions section. This can be different from the friendlyName.
Close #724