-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISIS Application Docs style overhaul #5617
Conversation
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5617". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5617". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5617". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5617". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
Hmm, what browser are you using? There is a down arrow that's supposed to be there, it shows up in my testing so far. Line 34 of ISISApplicationDocStyle.css is meant to put it there:
I wonder if your browser doesn't recognize the [aria-expanded="false"] css condition for some reason? |
Is there a down arrow on the government "Here's how you know" banner at the top? |
No, that is missing as well for me. |
I can't reproduce, all icons show up on Chrome and Firefox for me. Did you try your browser's hard reload (Cmd + Shift + R, I think)? I wonder if it cached a gov-banner from a different site where it's positioned slightly different? Really weird the inconsistency though, only up arrows work in chrome, down arrows in parameters but not banner in Firefox. Are you building the docs differently than me? From
|
That was my issue. I was just opening the index.html into a browser. |
Description
Updates the ISIS Application docs pages to modern styling, including required header and footer, as well as styling reflecting USWDS guidance.
Related Issue
#5619
How Has This Been Validated?
Docs have been built and visited locally. In particular, the docs Homepage, TOCs, and random Application docs pages have been visited.
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: