Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mysql password 3 #2662

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix mysql password 3 #2662

wants to merge 4 commits into from

Commits on Aug 25, 2024

  1. URL encode variables that go into a MySQL credentials URI 

    See for reference:
- https://dev.mysql.com/doc/refman/8.0/en/connecting-using-uri-or-key-value-pairs.html#connecting-using-uri
- https://symfony.com/doc/current/doctrine.html
but note that we must use `rawurlencode` instead of `urlencode` which
differ in how they encode a space (as tested).

Fixes: #2651
Closes: #2502 as this is likely fixed but I couldn't reproduce it
    @eldering
    eldering committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    5bbe2ea View commit details
    Browse the repository at this point in the history

  2. Add command to update DB user password to current from file 

    There was no easy way to do this, besides also completely
dropping and recreating an empty database.
    @eldering
    eldering committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    e5fd474 View commit details
    Browse the repository at this point in the history

  3. Fixes for supporting passwords with weird characters 

    Use URL encoding in DATABASE_URL and return mysql_options
as an array (via ugly global variable), so each element
in it can be separately added to the command line using
`@` for expansion.
    @eldering
    eldering committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    e371261 View commit details
    Browse the repository at this point in the history

  4. Test plenty of weird characters in CI job MySQL password

    @eldering
    eldering committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    8cecda3 View commit details
    Browse the repository at this point in the history