Fix highlighting of in-freeze submissions by introducing separate met… #2692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adata. Previously, we did try to use the same metadata attribute in different scenarios and this was causing unrelated things to break (e.g. when having the triangles on the jury scoreboard, we would also incorrectly still show pending submissions in the scoreboard.json in the API). Note that as a side effect, this will no longer show "x + y tries" for submissions that happened in the freeze on the jury scoreboard (as we did before we introduced the blue triangles).
nickygerritsen
approved these changes
Sep 17, 2024
eldering
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…adata.
Previously, we did try to use the same metadata attribute in different scenarios and this was causing unrelated things to break (e.g. when having the triangles on the jury scoreboard, we would also incorrectly still show pending submissions in the scoreboard.json in the API).
Note that as a side effect, this will no longer show "x + y tries" for submissions that happened in the freeze on the jury scoreboard (as we did before we introduced the blue triangles).