Fix error handling / messaging on import validation errors.

[meisterT]

Fixes #2705.

While we are at it, also improve the usefulness of the error messages.

Example:

Command line:

webapp/bin/console api:call -m POST -f json=../Downloads/organizations.json users/organizations
04:17:58 ERROR     [request] Uncaught PHP Exception Symfony\Component\HttpKernel\Exception\BadRequestHttpException: "Error while adding organizations: Organization at index 36 ({"externalid":"U-3397","shortname":"","name":"Chalmers University of Technology","country":"SWE","icpc_id":null}) has errors:
  • `shortname`: This value should not be blank.

Organization at index 42 ({"externalid":"U-3758","shortname":"","name":"King's College London","country":"GBR","icpc_id":null}) has errors:
  • `shortname`: This value should not be blank.

Organization at index 67 ({"externalid":"U-8102","shortname":"","name":"University of Passau","country":"DEU","icpc_id":null}) has errors:
  • `shortname`: This value should not be blank.

" at UserController.php line 131 ["exception" => Symfony\Component\HttpKernel\Exception\BadRequestHttpException^ { …}]

[sentry-io]

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: webapp/src/Service/ImportExportService.php

Function	Unhandled Issue
App\Service\ImportExportService::importGroupData	TypeError: App\Entity\TeamCategory::setAllowSelfRegistration(): Argument #1 ($allowSelfRegistration) must be... /src/Entity/TeamCa... Event Count: 1

---

_{Did you find this useful? React with a 👍 or 👎}

[eldering]

Just a comment that the spec does not have shortname, only name and formal_name, see https://ccs-specs.icpc.io/draft/contest_api#organizations, so the error message is a bit confusing since it refers to internal attribute names, not the ones from the spec.

[meisterT]

Just a comment that the spec does not have shortname, only name and formal_name, see https://ccs-specs.icpc.io/draft/contest_api#organizations, so the error message is a bit confusing since it refers to internal attribute names, not the ones from the spec.

Yep, since error handling is a little bit opaque it is kinda non-trivial to change though. I will merge this as it is clearly better than a silent failure and then we can discuss with Nicky when he is back how to best improve it.