download file when submission is single source #2714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: webapp/src/Controller/Team/SubmissionController.php
📄 File: webapp/src/Service/SubmissionService.php (Click to Expand)
Did you find this useful? React with a 👍 or 👎 |
meisterT
reviewed
Sep 22, 2024
| } | ||
|
|
||
|
|
||
| public function getSubmissionFileNums(Submission $submission): int |
There was a problem hiding this comment.
nit: I would prefer the name getSubmissionFileCount (and I assume we can mark it as private)
There was a problem hiding this comment.
Ok, Should I modify it once more, or will you handle the changes when merging?
vmcj
reviewed
Sep 23, 2024
as6325400
force-pushed
the
8.3.1_download_code
branch
from
05e85a5
to
7e61cba
Compare
add spaces before/after, change method name, change download content type Update webapp/src/Service/SubmissionService.php Co-authored-by: MCJ Vasseur <[email protected]> Update webapp/src/Controller/Team/SubmissionController.php Co-authored-by: MCJ Vasseur <[email protected]> Update webapp/src/Service/SubmissionService.php Co-authored-by: MCJ Vasseur <[email protected]>
as6325400
force-pushed
the
8.3.1_download_code
branch
from
7e61cba
to
28df311
Compare
meisterT
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is only one uploaded file, download the file directly instead of downloading a compressed file.