Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the line chart to a bar chart. #2727

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

as6325400
Copy link
Contributor

@as6325400 as6325400 commented Sep 29, 2024

Bar Chart

Bar Chart

Origin Chart

Origin Chart

It has been changed to a bar chart. Personally, I don't think the difference is significant.

@mpsijm
Copy link
Contributor

mpsijm commented Sep 29, 2024

I do prefer the bar chart, makes it clearer that we're looking at individual submissions per bin 😄 Talking about bins, what was the idea again for contests that run for (way) longer than 5 hours? 🙂

Also, the x-axis looks off: why does it use multiples of 17 instead of 15? 🤔

@as6325400
Copy link
Contributor Author

I do prefer the bar chart, makes it clearer that we're looking at individual submissions per bin 😄 Talking about bins, what was the idea again for contests that run for (way) longer than 5 hours? 🙂

Also, the x-axis looks off: why does it use multiples of 17 instead of 15? 🤔

Regarding the x-axis, it's likely due to RWD (Responsive Web Design). The original version also adjusts the ticks automatically, so I'll take a look into it later.

As for the bins, I think we can set it to max(300, number of minutes) bins, since most contests don't exceed 5 hours.

@as6325400
Copy link
Contributor Author

Is it acceptable to use max(300, number_of_minutes) as the interval count?

Should I submit this change in this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants