Limit the labels on the x-axis #2732
Conversation
| let this_minute_submission_nums = 0; | ||
| submission_stats.forEach(stat => { | ||
| this_minute_submission_nums += stat.values[minute][1]; | ||
| }); | ||
| max_submissions_per_minute = Math.max(max_submissions_per_minute, this_minute_submission_nums); | ||
| } | ||
|
|
||
| function generate_values(start_point, end_point, number_of_points) { |
There was a problem hiding this comment.
I think we can this both simpler and nicer:
This will make sure that the ticks we use are still limited but are nice. In the default 5h long contest, every 15 minutes there is a tick, for longer contests, it increases to 30mins, 60mins and so on.
// Pick a nice round tickDelta and tickValues
var tickDelta = 15;
while (contest_duration_minutes / tickDelta > 15) {
tickDelta *= 2;
}
var tickValues = Array.from({ length: Math.ceil(contest_duration_minutes / tickDelta) + 1 }, (_, i) => i * tickDelta);
There was a problem hiding this comment.
So, the unit will always be in minutes?
If we take a classroom scenario, it's quite common for a contest to last an entire semester.
There was a problem hiding this comment.
You are right that we also would want to fall back to larger units than minutes when the contest duration is that long - I assume we should do that in the same change that adds the limitation to 300 buckets/bars. Do you rather want to do this in this PR or separately?
There was a problem hiding this comment.
Let's handle it separately.
update delta
Old PR
#2727
Change
Since the
forceXmethod is no longer available after usingmultibarchart, it causes the x-axis labels to be misaligned, and I can't set the competition end time as the final label. Therefore, I force interpolation to fill in the x-axis labels (I haven't thought of a better solution yet).In addition to 0 and the end time, I will insert 9 additional points. This should handle all competitions where the duration is a multiple of 10.
Next
Additionally, according to the last PR, the data size of the table uses
min(minutes, 300). How should I create the labels in this case? For example, if there is a competition that lasts for a week, should the unit of my labels still be in minutes?