Reimplementation of my recent sort fixes to solve further issues #2456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bab4f76.
…ing by recent (DS-Homebrew#2433)" This reverts commit d38e825.
…into recent-sort-refix
mentusfentus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
This reimplements two of my previous commits: DSi-Based themes: Fix broken game detection when sorting by recent #2433 and DSi-Based Themes: Fix recent sort, again #2448. These commits have been reverted in favor of a completely different approach that avoids modifying
CURPOSto prevent bugs.This also fixes a bug where the wrong ESRB screen appears and wrong per game settings are loaded when using recent sort.
Where have you tested it?
I've tested this for a few days and haven't encountered any more issues.
Pull Request status